Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace data-test-id with data-test #13292

Merged
merged 1 commit into from
Feb 23, 2021
Merged

test: replace data-test-id with data-test #13292

merged 1 commit into from
Feb 23, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Feb 23, 2021

SUMMARY

Replace global default testAttributeId for React Testing Library to data-test as it has been used in many places for Cypress tests already.

See: #13286 (comment)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud ktmud requested a review from nytai February 23, 2021 01:56
@ktmud ktmud mentioned this pull request Feb 23, 2021
Merged
@codecov-io
Copy link

codecov-io commented Feb 23, 2021 •
edited
Loading

Codecov Report

Merging #13292 (b6feb95) into master (974f447) will decrease coverage by 4.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13292      +/-   ##
==========================================
- Coverage   77.14%   72.83%   -4.31%     
==========================================
  Files         865      567     -298     
  Lines       44961    20677   -24284     
  Branches     5415     5415              
==========================================
- Hits        34686    15061   -19625     
+ Misses      10152     5493    -4659     
  Partials      123      123
Flag Coverage Δ
cypress 58.54% <ø> (ø)
javascript 62.17% <ø> (ø)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/components/ModalTrigger/index.jsx 100.00% <ø> (ø)
superset/dao/exceptions.py
superset/security/manager.py
superset/reports/commands/delete.py
superset/examples/css_templates.py
superset/viz.py
superset/queries/schemas.py
superset/db_engine_specs/trino.py
superset/app.py
superset/stats_logger.py
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974f447...b6feb95. Read the comment docs.

@ktmud ktmud force-pushed the rtl-use-data-test branch from cf88fb4 to b6feb95 Compare February 23, 2021 02:28
@yardz
Copy link
Contributor

yardz commented Feb 23, 2021

@nytai Can you approve this PR? As I'm implementing tests I need this to open some PRs.

@nytai nytai merged commit e4a0233 into apache:master Feb 23, 2021
@yardz yardz mentioned this pull request Feb 23, 2021
Merged
6 tasks
@ktmud ktmud deleted the rtl-use-data-test branch February 23, 2021 21:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ktmud @codecov-io @yardz @willbarrett @nytai @mistercrunch